Puzzles/add dcr base page pipeline - #16656
Merged
Merged
Conversation
…complete html doc
… POST /PuzzlesPage for prod & dev
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:c2e972555658e482ba17292958b80a21abd663880d766e41f2978a041a55fc83"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-puzzles-add-dcr-base-page-pipeline"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-30749"
# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-428128cc38de993c768063f7a9f5d112364be290"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/deployTools --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE |
gustavo-olmedo
marked this pull request as ready for review
September 2, 2026 09:35
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
andresilva-guardian
approved these changes
Sep 2, 2026
gustavo-olmedo
enabled auto-merge
September 3, 2026 07:44
gustavo-olmedo
disabled auto-merge
September 3, 2026 07:44
…es (#16600) Bumps the storybook group with 4 updates in the / directory: [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y), [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/docs), [@storybook/react-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-webpack5) and [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/core). Updates `@storybook/addon-a11y` from 10.5.7 to 10.5.10 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.5.10/code/addons/a11y) Updates `@storybook/addon-docs` from 10.5.7 to 10.5.10 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.5.10/code/addons/docs) Updates `@storybook/react-webpack5` from 10.5.7 to 10.5.10 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.5.10/code/frameworks/react-webpack5) Updates `storybook` from 10.5.7 to 10.5.10 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.5.10/code/core) --- updated-dependencies: - dependency-name: "@storybook/addon-a11y" dependency-version: 10.5.10 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: storybook - dependency-name: "@storybook/addon-docs" dependency-version: 10.5.10 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: storybook - dependency-name: "@storybook/react-webpack5" dependency-version: 10.5.10 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: storybook - dependency-name: storybook dependency-version: 10.5.10 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: storybook ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Seen on PROD (merged by @gustavo-olmedo 8 minutes and 53 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds the base DCR puzzles-page pipeline.
The new POST /PuzzlesPage endpoint:
It also adds the puzzles-page types, shared experiment helper, development and production routes, render function, base page components and unit tests.
The blueprint-driven directory and final visual design will be implemented in the following tickets.
Why?
The Frontend /puzzles route added in the previous tickets needs a dedicated DCR endpoint.
Frontend builds the puzzles-page payload and sends it to POST /PuzzlesPage. DCR validates the data, applies the experiment guard, renders the base HTML document and returns it to Frontend.
This establishes a safe foundation for the following puzzles layout, styling and interaction work.
How has this change been tested?
Automated tests
Added Jest tests covering:
The focused Jest tests and TypeScript checks pass.
Manual testing
Deployed to CODE and verified that:
Screenshots
Not applicable. This PR establishes the page contract and rendering pipeline. The final blueprint-driven visual layout is covered by the following tickets.